-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve svg rendering #974
Conversation
…oke-width adjusted fill for (geom2) continous paths
@hrgdavor please review / try if you have time. I think these changes will help users when exporting to SVG. |
See #558 for how to add a ‘name’ to objects. Probably, support for ‘id’ and ‘class’ is enough. |
np. I will take a look a bit and test |
It will be few days before I can do so, I am traveling today and tomorrow, so I can't test this right away |
I have some complaint/proposals that are unrelated to this PR. jscad is generating poly for each curve immediately, so an export to SVG is a poly instead of circle, arc, besier. Without changing jscad core, one option would be to explore integration with other 2d libs like maker.js ... actually all that is needed is to improve require in the future because V2 now allows us to script with any valid JS lib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good step forward.
These changes improve the 'rendering' of designs exported to SVG.
All Submissions: