Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(all): changes to comply with lint #1367

Merged
merged 14 commits into from
Nov 10, 2024
Merged

style(all): changes to comply with lint #1367

merged 14 commits into from
Nov 10, 2024

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Nov 9, 2024

These changes are syntax only, changes to correct lint warnings.

The Github CI has also been bumped to use Node 16 and Node 18, which is still behind the LTS versions.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev z3dev requested review from hrgdavor and platypii November 9, 2024 04:16
@z3dev
Copy link
Member Author

z3dev commented Nov 9, 2024

@platypii @hrgdavor please review

@z3dev z3dev requested a review from platypii November 10, 2024 01:19
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing better than removing code

@z3dev z3dev merged commit 0e6215a into master Nov 10, 2024
4 checks passed
@z3dev z3dev deleted the cleanup-v2-part-1 branch December 29, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants