Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with gem_excludes not being used on bundler gems #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fzakaria
Copy link

This is an upstream commit authored by @stalbot.

Unclear why in the original code exclude_gems was set to false if any files were found in the Git gem. It caused the condition to check for config.gem_excludes to not trigger.

(Looks like gem_excludes will not work neither when spec.source is ::Bundler::Source::Path)

Co-authored-by: Steven Talbot [email protected]

@fzakaria fzakaria requested a review from headius February 5, 2020 02:10
@fzakaria
Copy link
Author

fzakaria commented Feb 5, 2020

Would a test be needed for this change ?
I'd like to make sure it gets merged.

@fzakaria
Copy link
Author

fzakaria commented Feb 5, 2020

The Travis failures are not related to the change:

Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    jbundler (~> 0.9) java was resolved to 0.9.3, which depends on
      bundler (~> 1.5) java
  Current Bundler version:
    bundler (2.1.4)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

@kares
Copy link
Member

kares commented Feb 9, 2020

yes, please possibly add a test regardless of CI

@fzakaria
Copy link
Author

The unit tests are more complicated -- this might take me a little bit.
I've never heard of DRB :)

What's the state of Warbler ?
Is it still the recommended approach by JRuby to build a JAR?

I'm curious due to the state of the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants