generate ibuffer filter groups from eproject info #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this kind of feel more like an ibuffer feature than an eproject feature? It should be easy to pick any filter to toggle on and off with a key-binding; not just eproject. I'd appreciate it if you opened a bug in the eproject issue tracker noting that we should try to push this feature upstream and add a ;;; TODO(dcrewi) comment with the link to the issue and a description. Then I will merge this PR and hopefully we will remember to talk to the ibuffer folks and see if we can push a more generic mechanism upstream. As always, thanks very much for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.