This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Improve on KeychainItemAccessibility
#159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbertix
changed the title
KeychainItemAccessibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version and platform specific logic in order to bypass deprecation warnings, fixing #156.
NSKeyedArchiverandNSKeyedUnarchivermethodskSecAttrAccessibleAlwaysandkSecAttrAccessibleAlwaysThisDeviceOnlyDefaulting
.alwaysto.afterFirstUnlock, and.alwaysThisDeviceOnlyto.afterFirstUnlockThisDeviceOnly, on iOS 12.0 and above, my initial implementation, didn't feel like the optimal choice.It truly felt like the only sensible thing to do was marking
.alwaysand.alwaysThisDeviceOnlyasunavailablefor everyone, while allowing users that genuinely need to rely on those cases to pass them themselves, with the addition of a.customcase.I did not include
macCatalystin the#availablestatements, as the minimum Swift version for using the library is still set to4.1.