Add promise support for missing fs methods #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because |
RyanZim
force-pushed
the
ryan/missing-fs-methods
branch
from
ed11fe2 to
58c8d91
Compare
|
Temporarily fixed the macOS version to work around this |
For that it would make sense to drop the support for 14.x and 16.x, and start supporting newer versions, at least in GitHub Actions. WDYT? |
JPeer264
approved these changes
Jan 11, 2025
|
Yeah, we should drop old Node versions, but that'd be a separate breaking change, and I'd like to do some thinking about other breaking changes we should include in the major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
Somehow, I added a comment about
fs.cpbut never added it to the list 🤷♂️