Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix ada issues #43

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat: fix ada issues #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/elements-core/src/components/Docs/HttpOperation/Callbacks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const Callbacks = ({ callbacks }: ICallbacksProps) => {
{callbacks?.map(callback => (
<Panel rounded isCollapsible={true} key={`callback-${callback.id}`}>
<Panel.Titlebar bg="canvas-300">
<Box as="span" role="heading">
<Box as="span">
{callback.path}
</Box>
</Panel.Titlebar>
Expand Down
2 changes: 1 addition & 1 deletion packages/elements-core/src/components/Docs/HttpService/AdditionalInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const AdditionalInfo: React.FC<AdditionalInfoProps> = ({ id, termsOfServi
return contactLink || licenseLink || tosLink ? (
<Panel rounded isCollapsible={false} pos="relative">
<Panel.Titlebar bg="canvas-300">
<span role="heading">Additional Information</span>
<span>Additional Information</span>
</Panel.Titlebar>

<Panel.Content p={0}>
Expand Down
4 changes: 2 additions & 2 deletions packages/elements-core/src/components/Docs/HttpService/SecuritySchemes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const SecuritySchemes: React.FC<SecuritySchemesProps> = ({
return (
<Panel rounded isCollapsible={defaultCollapsed} data-test="security-row">
<Panel.Titlebar bg="canvas-300">
<Box as="span" role="heading">
<Box as="span">
Security
</Box>
</Panel.Titlebar>
Expand Down Expand Up @@ -62,7 +62,7 @@ const SecurityScheme: React.FC<
return (
<Panel defaultIsOpen={defaultIsOpen} isCollapsible={isCollapsible} pos="relative">
<Panel.Titlebar>
<Box as="span" role="heading">
<Box as="span">
{getReadableSecurityNames(schemes, showSchemeKey)}
</Box>
</Panel.Titlebar>
Expand Down
2 changes: 1 addition & 1 deletion packages/elements-core/src/components/Docs/Model/Model.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ const ModelExamples = React.memo(({ data, isCollapsible = false }: { data: JSONS

return (
<Panel rounded isCollapsible={isCollapsible} defaultIsOpen={!isCollapsible}>
<Panel.Titlebar rightComponent={selectedExample ? <CopyButton size="sm" copyValue={selectedExample} /> : null}>
<Panel.Titlebar rightComponent={selectedExample ? <CopyButton size="sm" copyValue={selectedExample} /> : null} aria-label="copy example" >
{examplesSelect || (
<Text color="body" role="heading">
Example
Expand Down
2 changes: 1 addition & 1 deletion packages/elements-core/src/components/RequestSamples/RequestSamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const RequestSamples = React.memo<RequestSamplesProps>(({ request, embedd

return (
<Panel rounded={embeddedInMd ? undefined : true} isCollapsible={embeddedInMd}>
<Panel.Titlebar rightComponent={<CopyButton size="sm" copyValue={requestSample || ''} />}>
<Panel.Titlebar rightComponent={<CopyButton size="sm" copyValue={requestSample || ''} aria-label="copy request" />}>
<Box ml={-2}>
<Menu
aria-label="Request Sample Language"
Expand Down
2 changes: 1 addition & 1 deletion packages/elements-core/src/components/ResponseExamples/ResponseExamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const ResponseExamples = ({ httpOperation, responseMediaType, responseSta

return (
<Panel rounded isCollapsible={false}>
<Panel.Titlebar rightComponent={<CopyButton size="sm" copyValue={responseExample || ''} />}>
<Panel.Titlebar rightComponent={<CopyButton size="sm" copyValue={responseExample || ''} aria-label="copy response" />}>
{examplesSelect || <Text color="body">Response Example</Text>}
</Panel.Titlebar>
<Panel.Content p={0}>
Expand Down
4 changes: 4 additions & 0 deletions packages/elements-core/src/core.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,7 @@
height: 100%;
min-height: 36px;
}

.sl-select div[aria-hidden=true] {
display: none;
}
Loading