Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add poll_map feature #18

Merged
merged 3 commits into from
Mar 16, 2021
Merged

add poll_map feature #18

merged 3 commits into from
Mar 16, 2021

Conversation

robjtede
Copy link
Collaborator

checks off issue 63514 from #16

@jplatte
Copy link
Owner

jplatte commented Mar 15, 2021

Thanks for the PR :)

Can you split this into two files? I've generally been doing that for feature flags that are for a handful of methods on one type (as opposed to sth. like pointer or integer methods that are named the same thing but available on a bunch of distinct types, where I use items).

@jplatte
Copy link
Owner

jplatte commented Mar 15, 2021

One more thing: the titles should be enclosed in backticks (so they get rendered as <code>).

@jplatte jplatte merged commit 77b03af into jplatte:main Mar 16, 2021
@robjtede robjtede deleted the data-poll-methods branch March 16, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants