Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint upgrade #2086

Merged
merged 9 commits into from
Dec 24, 2024
Merged

Eslint upgrade #2086

merged 9 commits into from
Dec 24, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Dec 1, 2024

This PR upgrades eslint to version 9 and moves to the new flat config format.
Due to several dependencies being upgraded in the process new rules emerged. The code was updates to match these new rules.
The vast majority of these changes are switches in the order parmeters are given in markup

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Dec 1, 2024
@Kr0nox Kr0nox requested a review from a team December 1, 2024 06:57
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Dec 3, 2024
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one sonar issue, but besides that we can merge.

@Kr0nox
Copy link
Member Author

Kr0nox commented Dec 3, 2024

We first need to discuss the issue.
The problem is that e is not used in this case, but if it is just left, eslint will complain.
voiding it however makes sonarcloud complain.
One solution would be to ignore the eslint rule for that line

@tsaglam
Copy link
Member

tsaglam commented Dec 3, 2024

One solution would be to ignore the eslint rule for that line

It would be fine here, I think.

Copy link

@tsaglam tsaglam merged commit 6fe8166 into develop Dec 24, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants