Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pre-commit hook checking spotless #1881

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Added pre-commit hook checking spotless #1881

merged 10 commits into from
Aug 26, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Added pre-commit hook checking spotless

@TwoOfTwelve TwoOfTwelve marked this pull request as ready for review July 19, 2024 15:34
@TwoOfTwelve TwoOfTwelve requested a review from Kr0nox July 19, 2024 15:34
@TwoOfTwelve
Copy link
Contributor Author

@Kr0nox Can you take a look at the changes in the package.lock and that the scripts work on windows?

@Kr0nox
Copy link
Member

Kr0nox commented Jul 20, 2024

Works good. Although the package lock differs when i run npm i. Did you remove husky manually or using npm uninstall husky

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jul 22, 2024
@TwoOfTwelve
Copy link
Contributor Author

I removed it manually. I'll do that through uninstall instead. I didn't know that was a thing.

dfuchss
dfuchss requested changes Jul 25, 2024
View reviewed changes
gitHooks/installHooks.py Outdated Show resolved Hide resolved
gitHooks/hooks/pre-commit Show resolved Hide resolved
gitHooks/scripts/javaPreCommit Show resolved Hide resolved
@TwoOfTwelve
Copy link
Contributor Author

@Kr0nox I removed husky through npm uninstall. The changes look identical on my system.

@Kr0nox
Copy link
Member

Kr0nox commented Jul 27, 2024

@Kr0nox I removed husky through npm uninstall. The changes look identical on my system.

Then I would probably attribute that to a different node version. But everything still works with the current package-lock

@TwoOfTwelve TwoOfTwelve requested a review from dfuchss August 2, 2024 12:47
dfuchss
dfuchss requested changes Aug 2, 2024
View reviewed changes
gitHooks/installHooks.py Outdated Show resolved Hide resolved
gitHooks/scripts/reportViewerPreCommit Show resolved Hide resolved
dfuchss
dfuchss approved these changes Aug 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@TwoOfTwelve TwoOfTwelve requested a review from tsaglam August 13, 2024 20:46
@Kr0nox
Merge remote-tracking branch 'origin/develop' into feature/gitPreCommit
1412350 
# Conflicts:
#	report-viewer/package-lock.json
#	report-viewer/package.json
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit 79863df into develop Aug 26, 2024
53 checks passed
@tsaglam tsaglam deleted the feature/gitPreCommit branch August 26, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kr0nox Kr0nox Kr0nox approved these changes

@dfuchss dfuchss dfuchss approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TwoOfTwelve @Kr0nox @tsaglam @dfuchss