-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow single submissions #1852
Feature/allow single submissions #1852
Conversation
It fixes also this feature request: #1849. The code probably is to be reviewed by the maintainers and re-adjusted, but it works as a proof of concept |
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
@euberdeveloper reviews will follow. For now, please take a look at the Sonar issues and see which ones you can resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple e2e case to this pr, so we can make sure, it is always correctly exported.
Here are references on where they are implemented currently:
https://github.com/jplag/JPlag/blob/develop/report-viewer/tests/e2e/OpenComparisonTest.spec.ts
https://github.com/jplag/JPlag/blob/develop/.github/workflows/complete-e2e.yml
Please add one for every Problem solved by this PR
Ok, I will do it next week |
@euberdeveloper can you also extend the PR description so it becomes clearer what aspects this PR addresses and how it does so? Also how we can test it. We may need to discuss what features we want to include and which ones we don't want to include. Finally, please switch your target branch to develop, the main branch is only for releases. |
@tsaglam I've created a new branch that forks that:
Please take a look at it, I think that it is a good improvement that fixes #1849 and #1848 . For a description of what it does, you can take a look at those issues (#1849 and #1848 ), namely:
The pull request will reference this old one, that I'm closing |
Ref to #1445 and #1848, fixes #1850