Ensure JPlag fails gracefully if JavaC is not available and Java code is analyzed #1835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users run JPlag without a full JDK, and thus JavaC is not available. This manifests in an error like this:
To this end, this PR checks if JavaC is available by trying to load a corresponding class. If this does not work, it fails gracefully. To implement this, the exceptions of the API were extended: Language modules can now throw a
CriticalParsingException
, which leads to termination. The core uses a new subclass ofExitException
to wrap this and pass it to the top.