Report Viewer Demo #1448
Merged
Report Viewer Demo #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
the
report-viewer
|
You should be able to reuse the token |
|
|
Demo can be viewed here |
dfuchss
approved these changes
Jan 10, 2024
sebinside
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
I like the solution, let's see whether it will eventually break the build 😁 I just created an empty Demo repository.
For a future version, we should discuss whether the report viewer should directly open up the overview page in demo mode because the file upload view is a little bit pointless.
|
@Kr0nox should be fixed now. I've retriggered the Workflow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a demo for the report viewer. This demo will be hosted in a new repository (called demo) and will then be accessible on jplag.github.io/Demo/
The demo gets updated on each push to main.
We build jplag from its sources and then run it on the progpedia dataset. The results are inserted into the report viewer
To preview the demo locally, you have to add a report called
example.zipto the public folder in the report-viewer and then run:npx vite --mode demo@tsaglam Before the newly created workflow gets run (so either before the merge of develop into main or before it is run manually) please create an new repo called
Demoand create thegh-pagesbranch.@dfuchss Do you know whether we can reuse the token for the dev deploy in the workflow?