Merge pull request #1950 from jplag/report-viewer/search-name-id

Use name when processing search bar input
jplag · Aug 29, 2024 · d808ecd · d808ecd
2 parents 0a868f2 + 5a03f70
commit d808ecd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/report-viewer/src/components/ComparisonTableFilter.vue b/report-viewer/src/components/ComparisonTableFilter.vue
@@ -83,7 +83,7 @@ const searchStringValue = computed({
     }
 
     for (const submissionId of store().getSubmissionIds) {
-      const submissionParts = submissionId.toLowerCase().split(/ +/g)
+      const submissionParts = store().submissionDisplayName(submissionId).toLowerCase().split(/ +/g)
       if (submissionParts.every((part) => searchParts.includes(part))) {
         store().state.anonymous.delete(submissionId)
       }

diff --git a/report-viewer/src/components/ComparisonsTable.vue b/report-viewer/src/components/ComparisonsTable.vue
@@ -236,9 +236,9 @@ function getFilteredComparisons(comparisons: ComparisonListElement[]) {
 
   return comparisons.filter((c) => {
     // name search
-    const id1 = c.firstSubmissionId.toLowerCase()
-    const id2 = c.secondSubmissionId.toLowerCase()
-    if (searches.some((s) => id1.includes(s) || id2.includes(s))) {
+    const name1 = store().submissionDisplayName(c.firstSubmissionId).toLowerCase()
+    const name2 = store().submissionDisplayName(c.secondSubmissionId).toLowerCase()
+    if (searches.some((s) => name1.includes(s) || name2.includes(s))) {
       return true
     }