Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

new endpoint POST /device_report to test a report without a device #724

Merged
merged 7 commits into from
Apr 4, 2019
Merged

new endpoint POST /device_report to test a report without a device #724

merged 7 commits into from
Apr 4, 2019

Conversation

karenetheridge
Copy link
Contributor

closes #609.

@karenetheridge karenetheridge added enhancement extends current functionality api validation device reports Involves data coming from reporters labels Apr 3, 2019
@karenetheridge karenetheridge added this to the v2.27 milestone Apr 3, 2019
@karenetheridge karenetheridge requested review from sungo and perigrin April 3, 2019 21:48
sungo
sungo approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@sungo sungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the semantics of POST /device/:id vs POST /device_report are a little rough, the endpoints appear to line up with what I need

@karenetheridge karenetheridge merged commit 2036a39 into master Apr 4, 2019
@karenetheridge karenetheridge deleted the ether/validations-without-device branch April 4, 2019 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perigrin perigrin perigrin approved these changes

@sungo sungo sungo approved these changes

Assignees
No one assigned
Labels
api device reports Involves data coming from reporters enhancement extends current functionality validation
Projects
None yet
Milestone
v2.27
Development

Successfully merging this pull request may close these issues.

Ability to test a validation plan without an existing device
3 participants
@karenetheridge @sungo @perigrin