This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
device report retention changes #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
added
enhancement
karenetheridge
force-pushed
the
ether/device_report-retention
branch
from
e3dfdf5 to
d088336
Compare
perigrin
previously approved these changes
Feb 19, 2019
…e older passing reports We do not keep a device report if it follows a passing result and also is followed by a passing result. This means that we consider *previous* reports for deletion, never the most recent one. - remove duplicate device report detection logic (see #460, #492): we now once again process all device reports as they come in. - reorder validation_status_enum for nicer queries - create a command-line script to thin out historical reports. closes #619, #461.
karenetheridge
force-pushed
the
ether/device_report-retention
branch
from
d088336 to
edb28c1
Compare
perigrin
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run all incoming reports through validations, and then possibly delete older passing reports
We do not keep a device report if it follows a passing result and also is followed by a passing
result. This means that we consider previous reports for deletion, never the most recent one.
all device reports as they come in.
closes #619, #461.