fix: subscription procedure should use onData, not onNext

[david-bell-brown]

I referenced the implementation of the vanilla trpc client here since the v10 docs are light on the topic.

In a barebones vite project, without this fix any components using atomWithSubscription will be in suspense indefinitely without any noticeable error. This is with @trpc/[email protected]. I imagine this could all go out the window with v11.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[dai-shi]

The code looks good to me. I wonder if anyone else can review too.

So, if this fixes a bug, has there been an API change?

[david-bell-brown]

So, if this fixes a bug, has there been an API change?

Yeah, somewhere between trpc 9 and 10. Here is the same example implementation in version 9, which uses onNext. It also looks like it might have briefly been next before it was updated to onData here.

By the way, would it be helpful if I added a new example to this pr that uses subscriptions and websockets (and potentially httpSubscriptionLink later)? It looks like this feature is in for a roller coaster in the near future.

[dai-shi]

Yeah, somewhere between trpc 9 and 10. Here is the same example implementation in version 9, which uses onNext. It also looks like it might have briefly been next before it was updated to onData here.

Aright, that's wild. Anyway, I think the fix is good. Thanks for your help!

By the way, this repo is looking for a maintainer. Would you be interested in taking care of it?

[david-bell-brown]

By the way, this repo is looking for a maintainer. Would you be interested in taking care of it?

I could be. I think this stack has a lot of potential for realtime apps and multiplayer games, which I'm currently exploring, so I'll be keeping an eye on this for a while regardless. Maintaining a public repo would be something new for me, but this one seems pretty straightforward.

[dai-shi]

That's great!
I'm fine to let you fully maintain it, but if you feel nervous for doing something new, I can still help keeping eye on it.

I'll invite you to the repo later, and my suggestion for you are to:

• configure watching this repo for all activities,
• and, if you have a Discord account, join my server so that we can also communicate there.