Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trpc v11 #25

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

lukeramsden
Copy link

@lukeramsden lukeramsden commented Aug 2, 2024

#24

This at least demonstrates an example of some of the changes - they don't seem to be massive. With v11 not being stable yet however, it may not be worth merging this PR.

Doesn't seem to fix the examples, but I've not looked in to that yet, was just a pure port from the changelog.

. test:types:examples$ tsc -p examples --noEmit
│ examples/01_typescript/src/app.tsx(31,54): error TS7006: Parameter 'get' implicitly has an 'any' type.
│ examples/02_authtoken/src/app.tsx(37,4): error TS7006: Parameter 'get' implicitly has an 'any' type.
│ examples/02_authtoken/src/app.tsx(44,18): error TS7006: Parameter 'item' implicitly has an 'any' type.
└─ Failed in 863ms at /Users/lukeramsden/workspace/jotai-trpc
. test:spec$ vitest run
└─ Running...
 ELIFECYCLE  Command failed with exit code 2.
 ELIFECYCLE  Test failed. See above for more details.

Copy link

codesandbox-ci bot commented Aug 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@peterferguson
Copy link

peterferguson commented Sep 11, 2024

I think the maintainers of trpc DO consider v11 to be stable see the comment in the beta release.

If this PR is ready to merge maybe it is worth releasing it under a beta flag also?

Thoughts @lukeramsden @dai-shi

@dai-shi
Copy link
Member

dai-shi commented Sep 12, 2024

When it's ready I can release it. (Also, I'm looking for a maintainer.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants