Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not seem to work with tRPC v11 #24

Open
busybox11 opened this issue Jul 22, 2024 · 2 comments
Open

Does not seem to work with tRPC v11 #24

busybox11 opened this issue Jul 22, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@busybox11
Copy link

When using this lib with tRPC v11, the returned get callback inside atomWithQuery has any type definition, instead of the expected one. Can't reproduce in the example repo.

image
@dai-shi dai-shi added the help wanted Extra attention is needed label Jul 23, 2024
@dai-shi
Copy link
Member

dai-shi commented Jul 23, 2024

Thanks for reporting. We need someone to help this. cc @sachinraja

@lukeramsden
Copy link

Bit of investigation

Some imports deprecated and some removed.

Screenshot 2024-08-02 at 08 59 52

createTRPCProxyClient becoming createTRPCClient is simply a rename

Screenshot 2024-08-02 at 09 01 36

ProcedureArgs deleted

Lots of exports renamed for some reason? The migration changelog mentions general work to generics and simplification of types

Screenshot 2024-08-02 at 09 05 21

I've got createTRPCJotai.ts ported and compiling and will open a draft PR.

@lukeramsden lukeramsden mentioned this issue Aug 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dai-shi @lukeramsden @busybox11