Version 0.6.0 #6
Conversation
doloboyz
commented
Jun 6, 2024
doloboyz
commented
- Dependency updates
- added jsdoc comments to all functions
- Dependency updates - added jsdoc comments to all functions
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Not too sure as to why codesandbox CI is failing. Seems to be building successfully. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks for the suggestion. Don't worry about codesandbox. Do you think you can work to follow jotaijs/jotai-immer#9 ? |
|
Not sure if I understood correctly, but I made my best attempt at making repo compliant with the above provided packages. Unfortunately, it was riddled with some module resolution errors, hopefully you can provide a quick fix to this. |
tests/01_basic_spec.tsx
Outdated
| expect(src.atomWithMutation).toBeDefined(); | ||
| expect(src.atomWithSubscription).toBeDefined(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We need to change the file name to 01_basic.spec.tsx.
|
Can you run |
|
Let me know if you need anything else done |
|
I'll check it later. Do you have anything else you can do? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@doloboyz Hi, I added some fixes, but haven't tested if examples run correctly. |
|
So unfortunately, I don't believe module-first will work with the tsconfig files in the example subdirectories. I think commonjs needs to be used. If you want me to push the changes, I've implemented fixes for the examples. |
|
also after i adjusted the tsconfigs and package.json to use commonjs rather than module for the sake of the relay compiler, examples fail with 404 |
- Used commonjs module resolution in tsconfig.json - Changed 'AppCountriesQuery' to 'appCountriesQuery' in app.tsx to satisfy the relay compiler - Changed 'type' in package.json to 'commonjs' to satisfy relay
It's something I did in other repos, but I don't strongly suggest to do the same here. Also, as nobody else is maintaining this repo. I can invite you to be a maintainer of this repo. |
