adjust after comments on PR

jotaijs · Feb 27, 2024 · 80c21f9 · 80c21f9
1 parent 1491143
commit 80c21f9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/atomWithHash.ts b/src/atomWithHash.ts
@@ -26,9 +26,9 @@ export function atomWithHash<Value>(
   },
 ): WritableAtom<Value, [SetStateActionWithReset<Value>], void> {
   const serialize = options?.serialize || JSON.stringify;
-  let hashValueInURL;
-  if (global.window) {
-    hashValueInURL = new URLSearchParams(window.location.hash.slice(1)).get(
+  let initialValueInHash: string | null = null;
+  if (typeof window !== 'undefined') {
+    initialValueInHash = new URLSearchParams(window.location.hash.slice(1)).get(
       key,
     );
   }
@@ -57,7 +57,7 @@ export function atomWithHash<Value>(
   if (typeof setHashOption === 'function') {
     setHash = setHashOption;
   }
-  const strAtom = atom<string | null>(hashValueInURL ?? null);
+  const strAtom = atom(initialValueInHash);
   strAtom.onMount = (setAtom) => {
     if (typeof window === 'undefined' || !window.location) {
       return undefined;