fix variance value type

joshday · Sep 22, 2020 · 9a0020d · 9a0020d
1 parent 17e9388
commit 9a0020d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/stats.jl b/src/stats.jl
@@ -456,7 +456,7 @@ function _merge!(o::Variance, o2::Variance)
 end
 function value(o::Variance{T}) where {T} 
     if nobs(o) > 1 
-        o.σ2 * bessel(o) 
+        o.σ2 * T(bessel(o))
     else
         isfinite(mean(o)) ? T(1) ^ 2 : NaN * T(1) ^ 2
     end

diff --git a/test/test_stats.jl b/test/test_stats.jl
@@ -251,6 +251,8 @@ println("  > Variance")
     @test std(Variance()) == 1
     @test std(fit!(Variance(), 1)) == 1
     @test std(fit!(Variance(), [1, 2])) == sqrt(.5)
+    # https://github.com/joshday/OnlineStats.jl/issues/217
+    @test value(fit!(Variance(Float32), randn(Float32, 10))) isa Float32
 end
 
 end # end "Test Stats"