-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/responsiveness #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's take a look at tablet media query as well
@@ -171,53 +138,38 @@ h2{ | |||
flex-direction: column; | |||
justify-content: space-between; | |||
width: 80%; | |||
&-hydration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of SASS!
} | ||
|
||
|
||
@media only screen and (max-width: 900px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the media query! Do we have something for tablet or will our regular layout work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@media queries - thank you.
Pull Request
Description
Is this a feature or a fix?
FEATURE
Where should the reviewer start?
INDEX.HTML AND .SCSS FILES
What functionalities do these changes effect? Why were these changes made? What was the motivation behind these changes?
Changes the look on smaller screen size to fit mobile and tablets.
What outside features or research did you use to implement this fix?
NA
How should this be tested?
Open index.html then open mobile simulator with the dev tools.
Please review considerations below:
Follows Turing Style Guidelines
Changes generate no new warnings or errors
Checked code for and corrected any spelling errors
README has been updated(if applicable)