Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

feat: add autoflake, bandit, docformatter #992

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

qbedard
Copy link
Contributor

@qbedard qbedard commented Aug 5, 2022

Here are some more Python tools.

name = "bandit",
meta = {
url = "https://github.com/PyCQA/bandit",
description = "Bandit is a tool designed to find common security issues in Python code.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to mention in the description:

Since bandit doesn't get the original filename here, and is run via stdin, there is no way it respect can any excludes configured via a .bandit file.

( I had to hack around this temporarily until bandit accepts something like --stdin-filename).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely sounds like a good thing to mention, and we could add the workaround to the wiki and direct users there, too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timbedard Let me know if you want to do anything about this (I think putting this on the wiki and linking to it would be helpful). Other than that I think this is good to go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally down. I've just been busy. If either of you get to it before me, cool. Otherwise I'll try to tackle it when I have some spare time.

Copy link
Owner

@jose-elias-alvarez jose-elias-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Once we mention the bandit ignore issue in the documentation somewhere I think this is good to go.

@syphar
Copy link
Contributor

syphar commented Aug 8, 2022

with more time now, thank you @timbedard for adding this :)

@jose-elias-alvarez
Copy link
Owner

Let me know when you think this is okay!

@jose-elias-alvarez
Copy link
Owner

Thank you for your continued work on this PR! Everything looks good on my end, but again, let me know when you feel it's ready.

@choucavalier
Copy link

@timbedard thanks for working on this, any chance you can get it merged? :) i'm missing docformatter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants