This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
feat: add swipl #1600
Open
feat: add swipl #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks fine to me, but based on what I'm seeing, you are basically iterating over each line and matching against patterns, right? If so you may want to consider using the diagnostics.from_patterns helper, which could simplify your code a bunch and make future maintenance easier.
| end, | ||
| on_output = function(params, done) | ||
| local diagnostics = {} | ||
| local lines = vim.fn.split(params.err, "\r\n\\|\r\\|\n") |
There was a problem hiding this comment.
Small improvement: we could consider using vim.split here instead, which would simplify your check for emptiness a few lines down.
Edit: also, if you used the helper I mentioned, this would be handled automatically.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swipl
SWI-Prolog is a versatile implementation of the Prolog language.
Usage
Defaults
{ "prolog" }diagnosticsswipl{ "-q", "-t", "halt(1)", "-s", "$FILENAME" }