This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
feat(builtins/diagnostics/credo): toggle per file/full workspace diagnostics #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nostics Add `full_workspace` param to credo. When false (default), credo will run for current file in buffer. When true, will run credo globally for all files in the project workspace
madlep
commented
Mar 25, 2023
| if params:get_config().full_workspace then | ||
| -- this is hacky, but there isn't any way to set `multiple_files` | ||
| -- dynamically based on user config properly | ||
| params:get_source().generator.multiple_files = true |
There was a problem hiding this comment.
I tried a few different ways to dynamically set multiple_files based on user config, but without much luck.
Happy to modify this to a better approach if there's something I'm missing. Mutating the generator during on_output doesn't seem great, but couldn't find a better way that didn't involve messing with a bunch of core logic in null-ls.
|
This approach seems alright, but wouldn't a user be able to achieve the same results by overriding Alternatively: we could just add a separate source (e.g. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
full_workspaceboolean config param to credo.When
false(default), credo will run for current file in buffer - this preserves existing behaviour.When
true, credo will run globally for all files in the project workspaceAttached is a demo showing with config param disabled (default), then enabled.
full_workspace = truefor credo. nvim is opened again. When credo runs, project wide diagnostics are generated and populated (instead of just the current buffer).Screen.Recording.2023-03-25.at.11.11.12.pm.mov