This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Fix "Unable to find pkexec or kdesudo" error on NixOS #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, what is the status of this PR? We have a same issue maybe this PR solve it. |
|
This looks like a good fix for the issue I ran into ( |
|
I'd like this to be merged as well, although by the time it is I may have worked around this issue. |
|
Pretty please?.. |
|
Looks like this was fixed downstream in NixOS/nixpkgs#137912 |
|
Yes, it was me who applied that workaround and it's still a workaround. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
I reused the commit 0e933b7 that fallbacks to
whichif it cannot findkdesudoorpkexecin the hardcoded paths.Fixed "Error: User did not grant permission" (from #77 (comment)) by replacing
/bin/bashwith/usr/bin/env bash.Additional context
The above error ("Error: User did not grant permission") is very misleading because the underlying issue is that
/bin/bashcould not be found (the file does not exist on NixOS).In the future, it would be nice to refactor the error handling in https://github.com/jorangreef/sudo-prompt/blob/master/index.js#L188 so that the error message would be more descriptive.