New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline support #56

Open

masaccio wants to merge 6 commits into joopert:master from masaccio:multiline

masaccio commented Jan 21, 2023

This is the revised implementation of multiline support. Based on previous feedback:

interface is separated out from standard interface
implementation remains telnet-only for now
there's a new status_all method and status method; the latter mimics the TCP status method
multiline still relies on timeout happening to know when the end of the output happened
use of read_until relies upon the underlying transport testing whether the connection is still open and raising an exception if not

masaccio added 6 commits

January 21, 2023 10:40


          Refactoring

04ec0c5


          Add zone 2 volume/listeningmode

1da99a7


          Zone2 volume/listening mode

26e97ea


          Revert to master

2527b2e


          Sync with master HEAD

cc11091


          Add multiline interface for status

945acfe

Contributor

andreas-amlabs commented Jan 23, 2023

I will code review (and test) your changes, but right now I am swamped with other work - this will have to sit
a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet