-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Tag Router: Allow numeric/CSV IDs (Regression) #44784
base: 5.2-dev
Are you sure you want to change the base?
Conversation
Should there be system tests for this? |
I have tested this item ✅ successfully on a9b93b6 Not being 100% sure if this matters/is expected, but with the Patch turned on for:
There was no title (h1) in Bold above the Filter/Clear box: (Enter Part of Title) Filter/Clear box like you have for:
Apple if that is expected than it's perfect. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44784. (I added screenshots via Github) |
Hello @exlemor, thank you for testing this. Yes, the behavior is expected, since the /component/tags has no menu item attached to it and thus no configuration for the page. |
I have tested this item ✅ successfully on a9b93b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44784. |
Thank you for the tests. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44784. |
Pull Request for Issue #44703.
Summary of Changes
With Joomla 5.2.3 and PR #44540 the tag router was changed to rather throw a 404 when the URL was falsely extended by random segments. This unfortunately introduced a regression, where numeric segments and comma-separated lists of numeric IDs were treated as 404s. While by default all tag URLs should only produce alias-based URLs, we apparently have numeric URLs out there, which are now falsely are marked as broken. This PR checks for numeric IDs and for comma-separated IDs in the URL.
Testing Instructions
tagmenu
.Actual result BEFORE applying this Pull Request
Cases 2,3,4,9,10 return a page, all the rest throws a 404.
Expected result AFTER applying this Pull Request
Cases 15,16,17 throw a 404, the rest returns a successfull page.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed