[6.0] Delete 5.2.2-2024-09-24.sql update SQL scripts #44512
+2
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) deleted the "5.2.2-2024-09-24.sql" update SQL scripts from the sources and adds them to the list of files to be deleted on update in the script.php file.
Testing Instructions
Code review, or if you want to do a real test:
Update a recent 5.3-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.
The latest 5.3-dev nightly build can be found here: https://developer.joomla.org/nightlies/Joomla_5.3.0-alpha1-dev-Development-Full_Package.zip
The latest 6.0-dev nightly build update package can be found here: https://developer.joomla.org/nightlies/Joomla_6.0.0-alpha1-dev-Development-Update_Package.zip
The patched package created by Drone can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/6.0-dev/44512/downloads/80513/Joomla_6.0.0-alpha1-dev+pr.44512-Development-Update_Package.zip
Actual result BEFORE applying this Pull Request
After an update from a recent 5.3-dev nightly build to the latest 6.0-dev nightly build, the files
administrator/components/com_admin/sql/updates/mysql/5.2.2-2024-09-24.sqlandadministrator/components/com_admin/sql/updates/postgresql/5.2.2-2024-09-24.sqlare present.But that should not be the case, there should not be any 5.x update SQL scripts.
Expected result AFTER applying this Pull Request
After an update from a recent 5.3-dev nightly build to the patched package created by Drone for this PR, there are no 5.x update SQL scripts in folders
administrator/components/com_admin/sql/updates/mysqlandadministrator/components/com_admin/sql/updates/postgresql.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed