Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] contact thumbnail image #44502

Draft
wants to merge 5 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

When adding a thumbnail image for a contact it was hard coded to use the contact name as the alt text description. This is an invalid use of the alt text description.

This PR adds the ability to create your own valid alt text description or to mark it as a decorative image

Doing this in a way that is backwards compatible is challenging - still testing that

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Nov 21, 2024
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
@ChristineWk
Copy link

I have tested this item ✅ successfully on 31c8bfc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44502.

@brianteeman
Copy link
Contributor Author

@ChristineWk thanks for testing but this is still a draft and not ready for testing

@chmst The problem here is what do we do with existing contacts?
On a new contact image it would behave the same as a new article image. If there is an alt text description then it is used. If the checkbox for decorative is checked then an empty alt text description is used and if neither field is entered then no alt description is provided.
The problem is that on an existing site you do have an alt text description on all contact images generated from the contact title. We know thats not a good alt text description but I also dont believe we should alter an existing sites data by removing that. With the current code proposal all existing contact images would have their alt text removed making an existing site potentially less accessible than it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants