Make it compatible with Pydantic V2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in `setup.py` include adding `"SQLAlchemy-Utils"` to the `install_requires` list, indicating that the project now depends on this package. Based on the recent repository commits, it seems that the project is actively maintained and follows a conventional commit message style.
feat: Add SQLAlchemy-Utils to project dependencies
This commit refactors the `get_crontab_schedule` function in the `controller.py` file. The function now takes a `Session` and a `Schedule` as parameters and returns a `CrontabSchedule` object. The code has been formatted for better readability. Based on the recent repository commits, it seems that the project follows a conventional commit message style.
feat: Refactor get_crontab_schedule function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PydanticV2 has deprecated some of the decorators and methods used in the repo, generating warnings during testing.
Types of changes
Put an
xin the boxes that apply.fix): A non-breaking change which fixes an issue or bugfeat): A non-breaking change which adds a new feature or new functionalitytest): Adding missing tests or correcting existing testsrefactor): A code change that neither fixes a bug nor adds a feature, e.g Deleting unused or redundant codedocs): Documentation only changesstyle,build,ci,performance): Formatting, linting or styling. Changes to the CI pipeline. Performance improvements. Changes that affect the build system.Further Information