Skip to content

Commit

Permalink
Don't use deprecated apt-get --force-yes (#30) (#31)
Browse files Browse the repository at this point in the history
I noticed in my heroku build log that there's a bunch of `apt-get` warnings like this:

```
W: --force-yes is deprecated, use one of the options starting with --allow instead.
```

It looks like this line is the one responsible: https://github.com/jontewks/puppeteer-heroku-buildpack/blob/22c5b5960775a5befb89e8b9a1014bc8c1187e3f/bin/compile#L56

According to the [`apt-get` man page](https://manpages.debian.org/stretch/apt/apt-get.8.en.html),
we can use `--allow-downgrades --allow-remove-essential --allow-change-held-packages` instead.

Fixes #29
  • Loading branch information
josephfrazier authored and jontewks committed Oct 15, 2018
1 parent 0ee66b7 commit 704ea1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ for PACKAGE in $PACKAGES; do
curl -s -L -z $PACKAGE_FILE -o $PACKAGE_FILE $PACKAGE 2>&1 | indent
else
topic "Fetching .debs for $PACKAGE"
apt-get $APT_OPTIONS -y --force-yes -d install --reinstall $PACKAGE | indent
apt-get $APT_OPTIONS -y --allow-downgrades --allow-remove-essential --allow-change-held-packages -d install --reinstall $PACKAGE | indent
fi
done

Expand Down

0 comments on commit 704ea1e

Please sign in to comment.