Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vl-convert test specs and assorted fixes #53

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

jonmmease
Copy link
Owner

@jonmmease jonmmease commented Jan 31, 2024

Adds nearly all of the specs from the vl-convert test suite, and includes a bunch of fixes to make them pass:

  • Don't leave space for circle stroke when stroke is transparent
  • Use a user agent when fetching images with reqwest so that OSM servers are happy
  • Handle dx/dy in text marks
  • Support remote images in SVG format using resvg
  • Allow x/y props to be missing and null across all mark types
  • Switch from u16 to u32 indices in the basic mark type to support large paths
  • Allow text property of Vega text mark to be a number or null
  • Support sorting marks within groups by their zindex

Closes #46, #48

@jonmmease jonmmease merged commit 46b78c3 into main Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support text as number
1 participant