test: inherited props

jonlambert · Apr 26, 2022 · f2fb783 · f2fb783
1 parent 667436c
commit f2fb783
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -11,7 +11,8 @@ export function propose<
   OriginalProps extends ComponentProps<ComponentType>,
   SuppliedProps extends Partial<OriginalProps>
 >(Component: ComponentType, props: SuppliedProps, displayName?: string) {
-  type FinalProps = Omit<OriginalProps, keyof SuppliedProps> & Partial<SuppliedProps>;
+  type FinalProps = Omit<OriginalProps, keyof SuppliedProps> &
+    Partial<SuppliedProps>;
 
   const NewComponent: React.FC<FinalProps> = (p) => {
     const combinedProps = { ...props, ...p };

diff --git a/src/propose.test.tsx b/src/propose.test.tsx
@@ -11,6 +11,7 @@ describe('propose', () => {
     const Decorated = propose(Base, { message: 'hello, world' }, 'Decorated');
     expect(Decorated.displayName).toBe('Decorated');
   });
+
   it('renders correctly', () => {
     const Base: React.FC<{ message: string; title?: string }> = ({
       message,
@@ -52,4 +53,24 @@ describe('propose', () => {
     const { getByRole } = render(<Decorated title="Foo" message="Bar" />);
     expect(getByRole('heading')).toHaveTextContent('Foo');
   });
+
+  it('respects inherited props', () => {
+    interface SharedLinkProps {
+      variant: 'primary' | 'secondary';
+    }
+    interface LinkButtonProps
+      extends SharedLinkProps,
+        Pick<
+          React.DetailedHTMLProps<
+            React.ButtonHTMLAttributes<HTMLButtonElement>,
+            HTMLButtonElement
+          >,
+          'onClick'
+        > {}
+
+    const Base: React.FC<LinkButtonProps> = () => <div></div>;
+
+    const Derived = propose(Base, { variant: 'primary' });
+    render(<Derived onClick={() => {}} variant="primary" />);
+  });
 });