Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KFM5KAIFA support #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

IoannisPZP
Copy link

  • Add whitespace as possible character (used in messages)
  • Added KFM5KAIFA sample
  • Fixed typo for OBIS detection failure
  • removed assert for profilegeneric (not sure about this)

@jonkerj
Copy link
Owner

jonkerj commented Jan 5, 2023

Hi @IoannisPZP, thanks for your contribution! I've got a few remarks:

  • Could you use convententional commit subjects, so the releaser CI will version the next release properly?
  • Could you please split your four contributions into (I think three: whitespace and KFM5KAIFA are a single "feature") seperate comments? I'd like to avoid bundling seperate changes/improvements into combined commits

I am a bit unsure about including " " as a CHARACTER, as whitespace is treated differently when tokenizing. But then again, if the (improved) parser is able to parse all test messages correctly, it's fine by me.

@jonkerj
Copy link
Owner

jonkerj commented Mar 8, 2023

Hi @IoannisPZP, did you get a chance to look at my feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants