Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Webkit text size issue fixed? #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tatygrassini
Copy link

If you change -webkit-text-size-adjust: 100%; to -webkit-text-size-adjust: none; ... Or if you re-declare it below in the same selector, would this fixed the text size on iOS when changing from Portrait to Landscape view???

@jonikorpi
Copy link
Owner

The problem with "none" is that it disables text-size changing entirely in, for example, desktop Safari. "100%" also fixes the iOS text-size problem, but doesn't disable text-size changing in desktop browsers.

As far as I can tell from using "100%" for the past few months, it fixes the issue just fine. Is it not working for you then?

@tatygrassini
Copy link
Author

I was just trying to fix the weird mobile iOS bug when you view the site on landscape mode. Of course, "maximum-scale=1" is not an option. I was thinking about a CSS workaround.

How about applying the "none" declaration to something like @media screen and (min-width: 20em) ?

@jonikorpi
Copy link
Owner

Oh. You mean the zooming bug? That's entirely different from the text-size scaling behaviour: without -webkit-text-size-adjust: 100% (or none) Mobile Safari also increases the font-size of the page a little bit in landscape. http://www.456bereastreet.com/archive/201012/controlling_text_size_in_safari_for_ios_without_disabling_user_zoom/

The zooming bug has no real fix, since it's an actual bug. There's a hacky workaround available here: http://adactio.com/journal/4470/

@tatygrassini
Copy link
Author

Great hack right there! Bookmarked to use it with GGS.

After some reading, I wonder: if a designer starts a project using a mobile-first approach, when a mobile user change the device orientation, why would the user have the need to zoom in? (Assuming the design is perfectly readable and clear) I see some sort of dilemma here, more common sense related than technical.

You must have your reasons to exclude Shi Chuan's hack from your project, mind sharing why?

@jonikorpi
Copy link
Owner

I use zooming all the time myself, even on mobile sites, usually to zoom in on images or other small details. Sites that disable zooming piss me off like nothing else. I have perfectly normal eyesight, mind you. Can't even imagine how annoyed people with bad eyesight must get.

@tatygrassini
Copy link
Author

I use zooming the same way, except when designs have good and clear font size, 100%-wide images, etc. The hack you mentioned before supports zooming and fixes the landscape orientation bug.

Thanks a lot for the feedback and for the GGS project ;)

@jonikorpi
Copy link
Owner

Oh, heh, I actually read your question wrong there, sorry.

The reason I don't use the hack is that it's hacky and makes zooming feel weird. It usually makes my first pinch-to-zoom gesture get ignored somehow, and only kicks in on the second try.

@tatygrassini
Copy link
Author

Oh yeah, I'm aware of the "first pinch" bug, I appended Jeremy Keith's version (http://principiagastronomica.com/scripts/global.js) to the GGS.js file and it worked like a charm, no 2nd pinch needed. I'm testing this with an iPod Touch 2G, running iOS 4.2.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants