-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #82
base: main
Are you sure you want to change the base?
Bump deps #82
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
25aab85
to
2292e34
Compare
tokio-rustls = { version = "0.26", optional = true } | ||
rustls-platform-verifier = { version = "0.4", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've paged this out already (blame the holiday 😅), but do we have types from either of these in our public API (esp. in trait implementations)? If so, this change will require a major version bump for faktory as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our TlsStream
derefs to tokio_rustls
' stream.
Besides, TlsStream::with_client_config
accepts a config struct from rustls
. We are using rustls
re-exported from tokio_rustls
, and a major bump also took place there.
As for rustls-platform-verifier
- it's not part of our API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this probably - and unfortunately - should be a 0.14.0
release candidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's unfortunate. Yeah, I think let's maybe hold off then in case we see other breaking changes coming down the line 👍
This change is