-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "tls' feature workflow and basic test #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustworthy
force-pushed
the
chore/tls-test
branch
from
February 4, 2024 09:37
bd7d6b4
to
10010c9
Compare
rustworthy
changed the title
[WIP] Add "tls' feature workflow and basic test
Add "tls' feature workflow and basic test
Feb 4, 2024
rustworthy
commented
Feb 4, 2024
rustworthy
commented
Feb 4, 2024
rustworthy
commented
Feb 4, 2024
jonhoo
requested changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
rustworthy
commented
Feb 5, 2024
jonhoo
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, looks all good to me!
Released in 0.12.5 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker
directory in the project's root with the Faktory behind NGINX docker compose set-up;roundtrip
test to conditionally instantiate non-standard streams for Producer and Consumer;tls
workflow (thefaktory.local.crt
was self-signed, and the request was for 358000 days, so that the CI would not fail on it);Why
macos
runner excluded?It's super annoying :( Some runs will go [fine] (https://github.com/jonhoo/faktory-rs/actions/runs/7773048733/job/21196231638), another will fail with network error, or even worse - both will fail with the same connection refused. Also a tweak would be needed in the test like this:
So, not ideal, but staying the
ubuntu-latest
runner withstable
andbeta
channels testedThis change is