Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tls' feature workflow and basic test #53

Merged
merged 11 commits into from
Feb 11, 2024
Merged

Add "tls' feature workflow and basic test #53

merged 11 commits into from
Feb 11, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Feb 4, 2024

  • docker directory in the project's root with the Faktory behind NGINX docker compose set-up;
  • update the roundtrip test to conditionally instantiate non-standard streams for Producer and Consumer;
  • add tls workflow (the faktory.local.crt was self-signed, and the request was for 358000 days, so that the CI would not fail on it);

Why macos runner excluded?
It's super annoying :( Some runs will go [fine] (https://github.com/jonhoo/faktory-rs/actions/runs/7773048733/job/21196231638), another will fail with network error, or even worse - both will fail with the same connection refused. Also a tweak would be needed in the test like this:

let connector = if cfg!(target_os = "macos") {
            TlsConnector::builder()
                // Danger! Only for testing!
                // On the macos CI runner, the certs are not trusted:
                // { code: -67843, message: "The certificate was not trusted." }
                .danger_accept_invalid_certs(true)
                .build()
                .unwrap()
        } else { /* ..add the server cert to root certs .. */ }

So, not ideal, but staying the ubuntu-latest runner with stable and beta channels tested


This change is Reviewable

@rustworthy rustworthy changed the title [WIP] Add "tls' feature workflow and basic test Add "tls' feature workflow and basic test Feb 4, 2024
tests/real/community.rs Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@rustworthy rustworthy requested a review from jonhoo February 4, 2024 10:51
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

README.tpl Outdated Show resolved Hide resolved
docker/compose.yml Outdated Show resolved Hide resolved
docker/compose.yml Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
.github/workflows/tls.yml Outdated Show resolved Hide resolved
.github/workflows/tls.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@rustworthy rustworthy requested a review from jonhoo February 5, 2024 07:23
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, looks all good to me!

@jonhoo jonhoo merged commit 03f905f into main Feb 11, 2024
20 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Feb 18, 2024

Released in 0.12.5 🎉

@jonhoo jonhoo deleted the chore/tls-test branch February 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants