Cleaned up a few small things found in code review

jongpie · Oct 12, 2023 · bb3b92b · bb3b92b
1 parent e59d8c6
commit bb3b92b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/nebula-logger/core/main/log-management/classes/LogEntryHandler.cls b/nebula-logger/core/main/log-management/classes/LogEntryHandler.cls
@@ -261,8 +261,9 @@ public without sharing class LogEntryHandler extends LoggerSObjectHandler {
     }
 
     private void setCheckboxFields() {
-        // A formula field can't be used for checking if a long text area field is set/null
-        // So, this code handles maintaing some checkbox fields via Apex instead
+        // Long textarea fields can't be used in filters for SOQL, list views, etc, and a formula field can't be used
+        // for checking if a long text area field is set/null...
+        // So, this code handles maintaining some checkbox fields via Apex instead
         for (LogEntry__c logEntry : this.logEntries) {
             logEntry.HasDatabaseResultJson__c = logEntry.DatabaseResultJson__c != null;
             logEntry.HasExceptionStackTrace__c = logEntry.ExceptionStackTrace__c != null;

diff --git a/.../core/main/log-management/objects/LogEntry__c/fields/HasHttpRequestBody__c.field-meta.xml b/.../core/main/log-management/objects/LogEntry__c/fields/HasHttpRequestBody__c.field-meta.xml
@@ -5,7 +5,7 @@
     <complianceGroup>None</complianceGroup>
     <defaultValue>false</defaultValue>
     <externalId>false</externalId>
-    <label>Has HTTP Response Body</label>
+    <label>Has HTTP Request Body</label>
     <securityClassification>Confidential</securityClassification>
     <trackFeedHistory>false</trackFeedHistory>
     <trackTrending>false</trackTrending>

diff --git a/sfdx-project.json b/sfdx-project.json
@@ -14,7 +14,7 @@
             "path": "./nebula-logger/core",
             "definitionFile": "./config/scratch-orgs/base-scratch-def.json",
             "versionNumber": "4.11.10.NEXT",
-            "versionName": "Conditional Visibility for Fields LogEntry__c.HttpResponseHeaders__c and LogEntry__c.HttpResponseHeaderKeys__c",
+            "versionName": "Conditional Visibility for HTTP Response Headers",
             "versionDescription": "Added several new checkbox fields on LogEntry__c that correspond to each long textarea field, and updated LogEntryRecordPage.flexipage to have conditional visibility for the fields HttpResponseHeaderKeys__c and HttpResponseHeaders__c based on new checkbox fields",
             "releaseNotesUrl": "https://github.com/jongpie/NebulaLogger/releases",
             "unpackagedMetadata": {