Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set blocks closed by default #13

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dennisbaum
Copy link
Contributor

Hey @jongacnik, i would like to propose a feature, that blocks can initial be closed in the panel.
If we have lots of blocks, it's kind of a mess, when all blocks are open when editors open the page for the first time.
I already did the vue part, (hardcoded: atm all blocks are initial closed) but i would like to add a variable to the field. so the developer can decide, if blocks should be closed or visible at first time opening the page in the panel.
unfortunately that give me some challange. i am not that experienced with the PHP-Part of Field-Plugins.
So my question is:

  • Do you like the idea, that developers/editors can decide, blocks are initial opened or closed?
  • Could you support me with that feature?

@dennisbaum dennisbaum marked this pull request as draft November 15, 2022 07:45
@dennisbaum
Copy link
Contributor Author

Hola @jongacnik could you take a look and tell me whether that is interesting in principle, so i would look for a solution for the configuration thing. thx!

@jongacnik
Copy link
Owner

Hi @dennisbaum I think this is a sensible option to provide. Do you have it working yet with an option in the blueprint? I apologize for the delay, I haven't had much time to maintain open source projects outside of a busy work schedule.

@dennisbaum
Copy link
Contributor Author

hey @jongacnik totally understand the prob with the busy work schedule. unfortunetly i can't have a further look into the configuartion yet. but if you like the idea in general, i can invest more time or maybe aks one of the more experienced plugin-devs for help.

@medienbaecker
Copy link
Contributor

I had a closer look at how we could access a config option or something in the blocks' blueprints and unfortunately there's no easy way to do that. You can read more on Discord.

@jongacnik
Copy link
Owner

I had looked into this briefly as well, and yes, no good way of passing config through to the preview as of yet. Thanks for taking a closer look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants