-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build pyproj toml #948
base: master
Are you sure you want to change the base?
Conversation
Removed metadata that is now contained in the pyproject.toml. setup.py now only serves to house the custom build steps related to building Neuron's mod files.
We should also use this as an opportunity to consolidate other top-level configuration files into
|
1a11b12
to
81dd57a
Compare
fyi. I thought I could get away with adding [project.optional-dependencies]
opt = ['scikit-learn']
...
parallel = ['joblib', 'psutil', 'mpi4py ; platform_system != "Windows'] It actually worked preventing it from installing on Windows however... it broke the macOS unit test workflows because it was mixing and matching: getting mpi4py from pip and OpenMPI from conda. It couldn't find OpenMPI in the path for some reason. |
include-package-data = true | ||
|
||
[tool.setuptools.dynamic] | ||
version = {attr = "hnn_core.__version__"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this actually work? I suspect it will break ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the documentation on specifying dynamic metadata. I think it should work, it's pretty commonplace with toml specification. Just need the version defined in the top-level __init__.py
in the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try ... I think hnn_core.__version__
is not defined before installation. Maybe it works !
good idea to consolidate configuration in pyproject I suggest making the changes iteratively in small PRs. For now, if it works with pytest.ini and coveragerc I would be a happy man |
Regarding |
The parallel dependency group is a little weird... It might be best to get rid of that dependency group because it's super confusing. |
Making a PR for @gtdang 's work transitioning to
pyproject.toml