[MRG] Parallelize pytests where applicable #932
Conversation
|
Based on comparison to other recent test runs, this appears to shave about 3 minutes off of running the tests on the Macos and Linux github action runners. This especially helps speed up local testing. I will test making the same changes to Windows after I try installing it on a local Windows machine. |
asoplata
changed the title
| shell: bash -el {0} | ||
| run: | | ||
| python -m pytest ./hnn_core/tests/ --cov=hnn_core --cov-report=xml | ||
| python -m pytest ./hnn_core/tests/ -m "already_parallel" --cov=hnn_core --cov-report=xml --cov-append |
There was a problem hiding this comment.
maybe we should add this to the Makefile: https://github.com/jonescompneurolab/hnn-core/blob/master/Makefile
then you use the same command locally too. E.g.:
$ make already_parallel_testsThere was a problem hiding this comment.
and the make test has a dependency on already_parallel_tests and parallel_tests like so:
tests : already_parallel parallel_testscould you come up with slightly better names so the distinction between the two categories are clear?
There was a problem hiding this comment.
What about @pytest.mark.uses_mpi? That way it is unique, easy to understand (and grep), but also distinct from the other valid decorator @requires_mpi4py.
asoplata
force-pushed
the
parallelize-ci
branch
from
7c800e7 to
02e4391
Compare
asoplata
changed the title
asoplata
changed the title
|
Austin and I reviewed this together and it looks good and is ready to merge. |
No description provided.