-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Add method to modify synaptic gain #897
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
543d94a
add tests and type checks for synaptic gains
ntolley 1f040db
tests: updated test asset jones2009_3x3_drives.json
gtdang 70d1e6e
test: added gain to test_conn_to_dict
gtdang 0486a40
fix: added the update_weights method to the attributes to ignore list…
gtdang 35f601e
refactor: removed code for generation of unused test asset file
gtdang 8401a0c
test: updated check_equal_networks of test_gui.py
gtdang cac9ebf
test: refactored and added comments to test_synaptic_gains
gtdang 918b4a4
test: added test for changing two gains
gtdang a4c6a8b
test: added spot check to see if NetworkBuilder weights are multiplie…
gtdang 0159408
refactor: flake8
gtdang e271d2e
update whats_new
ntolley 7acf56d
Pass None as default
ntolley ba48c62
docstring spacing
ntolley 1bc8eb0
copy default to false
ntolley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the default behavior of the method be copy=False? Will most use cases be updating the weights in-place or saving to a new object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed! will change to false and then good to merge