[MRG] GUI n_drive_cells widget #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntolley
reviewed
Aug 14, 2024
| default_data = { | ||
| 'tstart': 0., | ||
| 'tstart_std': 0., | ||
| 'tstop': tstop_widget.value, | ||
| 'burst_rate': 7.5, | ||
| 'burst_std': 0, | ||
| 'repeats': 1, |
There was a problem hiding this comment.
any reason to remove repeats?
There was a problem hiding this comment.
I changed this to 'numspikes' to match the api for drive creation.
ntolley
reviewed
Aug 14, 2024
This was changed to not get confused with the cell_specific parameter of the drives.
numspikes was previously not passed to bursty drive construction. The widget was named "repeats" and was not used. The name was changed to "numspikes" to be consistent with the API.
-added input widget for n_drive_cells -renamed "sync_inputs" checkbox to "cell_specific" -set an observer to disable n_drive_cells widget if "cell_specific" is True -shortened argument names -updated default dictionary and update logic
-added input widget for n_drive_cells -renamed "sync_inputs" checkbox to "cell_specific" -set an observer to disable n_drive_cells widget if "cell_specific" is True -shortened argument names -updated default dictionary and update logic
-added input widget for n_drive_cells -renamed "sync_inputs" checkbox to "cell_specific" -set an observer to disable n_drive_cells widget if "cell_specific" is True -shortened argument names -updated default dictionary and update logic
-Tests more than one cell
The n_drive_cells parameter implementation now allows these asserts to pass.
gtdang
force-pushed
the
feat-gui-n-cells
branch
from
fe5ddbd to
7224abe
Compare
ntolley
reviewed
Aug 14, 2024
hnn_core/tests/test_gui.py
Outdated
| # Check that the n_drive_cells is not disabled | ||
| assert not gui.drive_widgets[0]['n_drive_cells'].disabled | ||
|
|
||
| # set synch inputs to first driver in simulation |
There was a problem hiding this comment.
Suggested change
| # set synch inputs to first driver in simulation | |
| # set sync inputs to first drive in simulation |
ntolley
reviewed
Aug 14, 2024
hnn_core/tests/test_gui.py
Outdated
| assert not gui.drive_widgets[0]['n_drive_cells'].disabled | ||
|
|
||
| # set synch inputs to first driver in simulation | ||
| driver_name = gui.drive_widgets[0]['name'] |
There was a problem hiding this comment.
Suggested change
| driver_name = gui.drive_widgets[0]['name'] | |
| drive_name = gui.drive_widgets[0]['name'] |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #853 merged first
Commits for this work start at 4789e9e. Previous are in #853.
Adds "number of drive cells" to the drive widgets.
Work done:
closes #850