-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Replace np.in1d()
with np.isin()
#799
Conversation
@ntolley i can squash and merge per our discussion yesterday if we're ready to go. seems like a straightforward substitution |
Looks like there might be some flake8 errors, though it looks like don't have anything to do with this PR. Hmmm... |
should you also bump up the minimum numpy version? |
@rythorpe fixed the flake8 errors! Also @jasmainak no need, |
@ntolley Seems like all tests passed except the linux. Shall we merge this so @kmilo9999 can continue testing the CI updates? |
Just one tiny comment, otherwise good to merge. |
Co-authored-by: Ryan Thorpe <[email protected]>
sounds good! everything should be addressed, whoever seeing the checks (besides ubuntu) go green feel free to merge |
Thanks @ntolley !! 🥳 |
Problem raised in #794 that numpy version 2.0.0 has deprecated
np.in1d()