-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Added BatchSimulate
class for batch simulations
#782
[MRG] Added BatchSimulate
class for batch simulations
#782
Conversation
Looks like a good start! Can you prepare an example so I can see the class in action? |
This comment was marked as resolved.
This comment was marked as resolved.
670a65c
to
8baa600
Compare
I meant that you should add it to the examples gallery :) |
150f201
to
54d65b4
Compare
As it stands ... the BatchSimulate does not really enable user to do more things by writing less code ... you need to brainstorm a bit how to make it more useful. Write the API first before starting to code. batch = BatchSimulate(func)
dpls = batch.simulate()
batch.plot_dpl() # plot dipoles in a grid
batch.plot_psd() # overlay multiple psds or plot in a grid I'm just dreaming ... but think of ways people may want to use such an API and how to simplify boilerplate code for them |
@jasmainak totally agree, I think the main utiluty of this function will be organizing code for saving/loading the potentially very large output files, along with some simulation metadata To make this use less code, I think the best way will be to decide on a limited set of predefined functions. Perhaps even a class that helps users quickly specify the parameters they care about: net = jones_2009_model()
func = make_evoked_simulator(net, weight_params='ampa', time_params='mean', custom_remove=['evprox1_L2Pyr_ampa'])
batch = BatchSimulate(func)
dpls = batch.simulate() However, I want to avoid this Perhaps this will be a good way to replace this function too! hnn-core/hnn_core/network_models.py Line 312 in aa773ec
|
957d0b8
to
724d001
Compare
after discussion with @jasmainak, useful features will include
|
724d001
to
9a0b4ac
Compare
15d9cd4
to
00ad420
Compare
1effef1
to
7ba6e2a
Compare
9c8e262
to
efa5de5
Compare
@ntolley, It seems like the linkcheck passes now. I removed the import statement from .batch_simulate import BatchSimulate from the |
efa5de5
to
f68b5d5
Compare
Really strange! There's definitely a step I'm forgetting in terms of adding a new file/class for importing. In any case really great start @samadpls, going to go ahead and merge and we can continue to improve on this in the next PR |
Closes #140