Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] DOC: add JOSS badge and CITATION.cff #700

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

rythorpe
Copy link
Contributor

No description provided.

@rythorpe
Copy link
Contributor Author

@jasmainak do you think we need a citation statement in the README as well, or is the badge and "Cite this repository" tab Github adds with CITATION.cff adequate?

@jasmainak
Copy link
Collaborator

jasmainak commented Dec 19, 2023 via email

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1216038) 91.34% compared to head (3c1531b) 91.34%.
Report is 2 commits behind head on master.

❗ Current head 3c1531b differs from pull request most recent head ffa287a. Consider uploading reports for the commit ffa287a to get more accurate results

Files Patch % Lines
hnn_core/gui/_viz_manager.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          25       25           
  Lines        4599     4599           
=======================================
  Hits         4201     4201           
  Misses        398      398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rythorpe rythorpe changed the title DOC: add JOSS badge and CITATION.cff [MRG] DOC: add JOSS badge and CITATION.cff Dec 19, 2023
@rythorpe
Copy link
Contributor Author

Here's how the citation section looks in the compiled README. If it looks good, feel free to merge @jasmainak.

image

@jasmainak jasmainak merged commit ab20341 into jonescompneurolab:master Dec 21, 2023
9 checks passed
@jasmainak
Copy link
Collaborator

Looks good, thanks @rythorpe !!

@rythorpe rythorpe deleted the update_readme branch December 21, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants