Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add missing icons for enabled accounts #900

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

opoto
Copy link
Contributor

@opoto opoto commented Apr 9, 2020

No description provided.

@gerhardol
Copy link
Collaborator

For use of icons, @12people removed previous versions of them in #654 as the use was not free.
Have you got other information?

@opoto
Copy link
Contributor Author

opoto commented Apr 9, 2020

I'm not legal expert, and I don't have detailed info.
What I used is:

So all in all:

  • I don't see any problem with Dropbox and Runalyze
  • Strava and RunKeeper is not official logos, but not sure this is an issue for RU
  • Endomondo might need to be updated

What do you think?

@gerhardol
Copy link
Collaborator

From the app perspective, an unofficial icon is OK.
The way the accounts are presented, I find it obvious that RU connect to these 3rd part services, not pretending to be part of them or even be endorsed.

The problem is if the owners request that the logos and usage should be removed, just to retain their ownership.
Google can be fickly to reactivate apps if they get such a request. (2.0 should be added to Play, even if it may have to be added to a new account.)

Strava

Strava guidelines mandates a "Connect with Strava" icon, so we have to use that and should change (to something slightly different).
https://developers.strava.com/guidelines/

Dropbox

I have tried to confirm to that page, good that you agree
(not changed here)

RunAlyze

For RunAlyze I got an OK to use the current icon. That icon is not usable as a favico, but I find it OK in the app, easier to relate to the logo.

Endomondo

The API is unofficial, but has been stable for years so it is at least tolerated.

RunKeeper

RunKeeper API is retired, to be deactivated and should not be updated.

@gerhardol
Copy link
Collaborator

Strava guidelines mandates a "Connect with Strava" icon, so we have to use that and should change (to something slightly different).
https://developers.strava.com/guidelines/

RU start page and TripleX description (used for F-Droid, should be used in Play too) need to be updated too (probably separate PR)

@opoto
Copy link
Contributor Author

opoto commented Apr 9, 2020

Ok, reverted changes on RunKeeper. Should I "disable" it in this PR, or do you want to use #701?
Maybe I can update README and full_description in #898?
For the "Connect to Strava" official icon, it cannot fit in the account list screen. So I just replaced with official Strava icon from https://blog.strava.com/fr/press/assets/. If you think RU has to include the dev icon, then what could be done is introduce a "large icon" for each synchronizer (defaulting to the existing one) to be used in the account edition screen.

@opoto
Copy link
Contributor Author

opoto commented Apr 9, 2020

@gerhardol
Copy link
Collaborator

I am not sure any of this can be included, trademark violations must be avoided. Sorry...

For Strava, the icon should be updated according to the Strava requirements, the press material cannot be used in the app.
Need to see what other apps are using if the update is tolerated or not
This is the service I care mostly about

For Dropbox, if this is the 'logo' from the API page I believe this is OK to change (I used the app icon). But it must not be changed from the original.

RunAlyze should have the existing icon in my view

RunKeeper should just be kept as is, removed when no longer working.

Endomondo is unofficial, keep as is

Update the readme here or in #898 if you prefer

@opoto
Copy link
Contributor Author

opoto commented Apr 10, 2020

Ok, so maybe we should just discard this PR then

@gerhardol
Copy link
Collaborator

Ok, so maybe we should just discard this PR then

Maybe Strava, Dropbox

@opoto
Copy link
Contributor Author

opoto commented Apr 11, 2020

OK, just kept Strava and Dropbox

@gerhardol
Copy link
Collaborator

Endomondo is added and Runalyze updated still.
I have not found so many other apps with these icons.
Runalyze: IpBike and LocusMap has the favico icon too (MyRunningApp has none).
Stgrava: IpBike has no primary icon, but the second page has the required "Connect with Strava". Other apps has a variant of this app.
Endomondo: I have not found other apps with upload or icons, the interface is unofficial, so let us keep it - I do not see that this is negative for Endomondo
Dropbox: Some variants are used in apps, the update should be allowed too.

So let us keep as is
I will squash merge unless you squash

@opoto
Copy link
Contributor Author

opoto commented Apr 14, 2020

Actually it is already squashed

@gerhardol gerhardol merged commit 58a8076 into jonasoreland:master Apr 14, 2020
@opoto opoto deleted the upd_account_icons branch April 14, 2020 21:49
@gerhardol
Copy link
Collaborator

master was merged to the feature branch, that should never bw done...
Squashed was OK
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants