-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and add missing icons for enabled accounts #900
Conversation
I'm not legal expert, and I don't have detailed info.
So all in all:
What do you think? |
From the app perspective, an unofficial icon is OK. The problem is if the owners request that the logos and usage should be removed, just to retain their ownership.
Strava guidelines mandates a "Connect with Strava" icon, so we have to use that and should change (to something slightly different).
I have tried to confirm to that page, good that you agree
For RunAlyze I got an OK to use the current icon. That icon is not usable as a favico, but I find it OK in the app, easier to relate to the logo.
The API is unofficial, but has been stable for years so it is at least tolerated.
RunKeeper API is retired, to be deactivated and should not be updated. |
RU start page and TripleX description (used for F-Droid, should be used in Play too) need to be updated too (probably separate PR) |
Ok, reverted changes on RunKeeper. Should I "disable" it in this PR, or do you want to use #701? |
Wiki should also be update |
I am not sure any of this can be included, trademark violations must be avoided. Sorry... For Strava, the icon should be updated according to the Strava requirements, the press material cannot be used in the app. For Dropbox, if this is the 'logo' from the API page I believe this is OK to change (I used the app icon). But it must not be changed from the original. RunAlyze should have the existing icon in my view RunKeeper should just be kept as is, removed when no longer working. Endomondo is unofficial, keep as is Update the readme here or in #898 if you prefer |
Ok, so maybe we should just discard this PR then |
Maybe Strava, Dropbox |
13506f1
to
dca3d52
Compare
OK, just kept Strava and Dropbox |
Endomondo is added and Runalyze updated still. So let us keep as is |
Actually it is already squashed |
master was merged to the feature branch, that should never bw done... |
No description provided.