This repository has been archived by the owner on May 18, 2022. It is now read-only.
Use a trait for representing attribute values #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use attributes in environments where using static lifetimes for attribute values is challenging by allowing the attribute service to use its own types that can choose how to store the attribute values. In addition, the usage of attribute in the AttributeProvider now takes a reference to the Attribute instead of a copy to allow the attribute service more freedom in implementing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use attributes in environments where using
static lifetimes for attribute values is challenging by allowing the
attribute service to use its own types that can choose how to store the attribute
values.
In addition, the usage of attribute in the AttributeProvider now takes a
reference to the Attribute instead of a copy to allow the attribute
service more freedom in implementing.
@jonas-schievink Consider this a proposal/draft to provide more flexibility of the attribute API as discussed in #153. I'm still not super-satisfied with this, given that the AttrValue implementation would need to cover all possible values for the different characteristics.